From: Davidlohr Bueso <dave@stgolabs.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: akpm@linux-foundation.org, tgraf@suug.ch,
linux-kernel@vger.kernel.org, Davidlohr Bueso <dbueso@suse.de>,
netdev@vger.kernel.org
Subject: Re: [PATCH] lib/rhashtable: consider param->min_size when setting initial table size
Date: Tue, 17 Jul 2018 15:30:57 -0700 [thread overview]
Message-ID: <20180717223057.7wdtjwbusxfqpvur@linux-r8p5> (raw)
In-Reply-To: <20180716000046.yscgnpr256qhm2qg@gondor.apana.org.au>
On Mon, 16 Jul 2018, Herbert Xu wrote:
>On Fri, Jul 13, 2018 at 11:25:16PM -0700, Davidlohr Bueso wrote:
>> rhashtable_init() currently does not take into account the user-passed
>> min_size parameter unless param->nelem_hint is set as well. As such,
>> the default size (number of buckets) will always be HASH_DEFAULT_SIZE
>> even if the smallest allowed size is larger than that. Remediate this
>> by unconditionally calling into rounded_hashtable_size() and handling
>> things accordingly.
>>
>> Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
>
>Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
>
>Normally these patches go through netdev so could you please resend
>it with my ack to netdev@vger.kernel.org?
So I've done the resend, but at least would think that routing the
patch through Andrew would work best as he picked up the rhashtable
changes regarding ipc and this touches the same call.
Thanks,
Davidlohr
next prev parent reply other threads:[~2018-07-17 22:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180714062516.30433-1-dave@stgolabs.net>
[not found] ` <20180716000046.yscgnpr256qhm2qg@gondor.apana.org.au>
2018-07-16 20:26 ` [PATCH resend -next] lib/rhashtable: consider param->min_size when setting initial table size Davidlohr Bueso
2018-07-18 20:28 ` David Miller
2018-07-17 22:30 ` Davidlohr Bueso [this message]
2018-07-18 1:58 ` [PATCH] " Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180717223057.7wdtjwbusxfqpvur@linux-r8p5 \
--to=dave@stgolabs.net \
--cc=akpm@linux-foundation.org \
--cc=dbueso@suse.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox