From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Borkmann Subject: [PATCH iproute2 2/5] bpf: move bpf_elf_map fixup notification under verbose Date: Wed, 18 Jul 2018 01:31:19 +0200 Message-ID: <20180717233122.29390-3-daniel@iogearbox.net> References: <20180717233122.29390-1-daniel@iogearbox.net> Cc: jakub.kicinski@netronome.com, alexei.starovoitov@gmail.com, netdev@vger.kernel.org, Daniel Borkmann To: dsahern@gmail.com Return-path: Received: from www62.your-server.de ([213.133.104.62]:34368 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730214AbeGRAGp (ORCPT ); Tue, 17 Jul 2018 20:06:45 -0400 In-Reply-To: <20180717233122.29390-1-daniel@iogearbox.net> Sender: netdev-owner@vger.kernel.org List-ID: No need to spam the user with this if it can be fixed gracefully anyway. Therefore, move it under verbose option. Signed-off-by: Daniel Borkmann --- lib/bpf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/bpf.c b/lib/bpf.c index 4e26c0d..42093db 100644 --- a/lib/bpf.c +++ b/lib/bpf.c @@ -1893,9 +1893,9 @@ static int bpf_fetch_maps_end(struct bpf_elf_ctx *ctx) } memcpy(ctx->maps, fixup, sizeof(fixup)); - - printf("Note: %zu bytes struct bpf_elf_map fixup performed due to size mismatch!\n", - sizeof(struct bpf_elf_map) - ctx->map_len); + if (ctx->verbose) + printf("%zu bytes struct bpf_elf_map fixup performed due to size mismatch!\n", + sizeof(struct bpf_elf_map) - ctx->map_len); return 0; } -- 2.9.5