From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next 1/8] net: dsa: mv88e6xxx: Abstract PTP
 operations
Date: Wed, 18 Jul 2018 09:40:28 +0900 (KST)
Message-ID: <20180718.094028.1268801023597255788.davem@davemloft.net>
References: <1531864140-31233-1-git-send-email-andrew@lunn.ch>
        <1531864140-31233-2-git-send-email-andrew@lunn.ch>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: richardcochran@gmail.com, vivien.didelot@savoirfairelinux.com,
        netdev@vger.kernel.org
To: andrew@lunn.ch
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([23.128.96.9]:54466 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1729934AbeGRBPj (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 17 Jul 2018 21:15:39 -0400
In-Reply-To: <1531864140-31233-2-git-send-email-andrew@lunn.ch>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Andrew Lunn <andrew@lunn.ch>
Date: Tue, 17 Jul 2018 23:48:53 +0200

> @@ -319,6 +337,8 @@ int mv88e6xxx_ptp_setup(struct mv88e6xxx_chip *chip)
>  {
>  	int i;
>  
> +	const struct mv88e6xxx_ptp_ops *ptp_ops = chip->info->ops->ptp_ops;
> +

Please keep the local variables together here.

Otherwise, this series looks good to me.