From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next 1/7] net: dsa: bcm_sf2: Allow targeting CPU
 ports for CFP rules
Date: Wed, 18 Jul 2018 09:56:37 +0900 (KST)
Message-ID: <20180718.095637.1597473427440931822.davem@davemloft.net>
References: <20180717153645.7500-1-f.fainelli@gmail.com>
        <20180717153645.7500-3-f.fainelli@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, linville@tuxdriver.com, andrew@lunn.ch,
        vivien.didelot@savoirfairelinux.com
To: f.fainelli@gmail.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([23.128.96.9]:54666 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1730380AbeGRBbw (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 17 Jul 2018 21:31:52 -0400
In-Reply-To: <20180717153645.7500-3-f.fainelli@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Florian Fainelli <f.fainelli@gmail.com>
Date: Tue, 17 Jul 2018 08:36:39 -0700

> @@ -755,7 +755,8 @@ static int bcm_sf2_cfp_rule_set(struct dsa_switch *ds, int port,
>  	port_num = fs->ring_cookie / SF2_NUM_EGRESS_QUEUES;
>  
>  	if (fs->ring_cookie == RX_CLS_FLOW_DISC ||
> -	    !dsa_is_user_port(ds, port_num) ||
> +	    !(dsa_is_user_port(ds, port_num) ||
> +	    dsa_is_cpu_port(ds, port_num)) ||

I think the second new line needs to be indented by two more
spaces, but I could be wrong :-)