From: David Miller <davem@davemloft.net>
To: hkallweit1@gmail.com
Cc: nic_swsd@realtek.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] r8169: power down chip in probe
Date: Wed, 18 Jul 2018 10:03:49 +0900 (KST) [thread overview]
Message-ID: <20180718.100349.761671025516145253.davem@davemloft.net> (raw)
In-Reply-To: <5bc628cd-b638-df9a-c0bc-5b15105a8fb1@gmail.com>
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Tue, 17 Jul 2018 21:21:37 +0200
> The removed code would be called in two situations:
> 1. interface is brought up never or >10s after driver load
> 2. after close()
>
> Case 1 we can handle cleaner by ensuring chip is powered down when
> leaving probe(). open() callback will power up the chip.
>
> In case 2 we call rtl_pll_power_down() twice currently, from the
> close() callback and 10s later when entering runtime-suspend.
> This is avoided by this patch.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Applied, thank you.
prev parent reply other threads:[~2018-07-18 1:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 19:21 [PATCH net-next] r8169: power down chip in probe Heiner Kallweit
2018-07-18 1:03 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180718.100349.761671025516145253.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).