From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next] r8169: power down chip in probe
Date: Wed, 18 Jul 2018 10:03:49 +0900 (KST)
Message-ID: <20180718.100349.761671025516145253.davem@davemloft.net>
References: <5bc628cd-b638-df9a-c0bc-5b15105a8fb1@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: nic_swsd@realtek.com, netdev@vger.kernel.org
To: hkallweit1@gmail.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([23.128.96.9]:54810 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1731096AbeGRBjE (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 17 Jul 2018 21:39:04 -0400
In-Reply-To: <5bc628cd-b638-df9a-c0bc-5b15105a8fb1@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Tue, 17 Jul 2018 21:21:37 +0200

> The removed code would be called in two situations:
> 1. interface is brought up never or >10s after driver load
> 2. after close()
> 
> Case 1 we can handle cleaner by ensuring chip is powered down when
> leaving probe(). open() callback will power up the chip.
> 
> In case 2 we call rtl_pll_power_down() twice currently, from the
> close() callback and 10s later when entering runtime-suspend.
> This is avoided by this patch.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Applied, thank you.