* [PATCH] net/rds: void function cannot return -1
@ 2018-07-16 13:00 Håkon Bugge
2018-07-16 16:29 ` Santosh Shilimkar
2018-07-18 5:44 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Håkon Bugge @ 2018-07-16 13:00 UTC (permalink / raw)
To: Santosh Shilimkar, David S . Miller
Cc: netdev, linux-rdma, rds-devel, linux-kernel
Commit b6fb0df12db6 ("RDS/IB: Make ib_recv_refill return void") did
not change the comment accordingly.
Fixes: b6fb0df12db6 ("RDS/IB: Make ib_recv_refill return void")
Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>
---
net/rds/ib_recv.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/rds/ib_recv.c b/net/rds/ib_recv.c
index b4e421aa9727..e5ce93419263 100644
--- a/net/rds/ib_recv.c
+++ b/net/rds/ib_recv.c
@@ -376,8 +376,6 @@ static void release_refill(struct rds_connection *conn)
* This tries to allocate and post unused work requests after making sure that
* they have all the allocations they need to queue received fragments into
* sockets.
- *
- * -1 is returned if posting fails due to temporary resource exhaustion.
*/
void rds_ib_recv_refill(struct rds_connection *conn, int prefill, gfp_t gfp)
{
--
2.14.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net/rds: void function cannot return -1
2018-07-16 13:00 [PATCH] net/rds: void function cannot return -1 Håkon Bugge
@ 2018-07-16 16:29 ` Santosh Shilimkar
2018-07-18 5:44 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Santosh Shilimkar @ 2018-07-16 16:29 UTC (permalink / raw)
To: Håkon Bugge, David S . Miller
Cc: netdev, linux-rdma, rds-devel, linux-kernel
On 7/16/2018 6:00 AM, Håkon Bugge wrote:
> Commit b6fb0df12db6 ("RDS/IB: Make ib_recv_refill return void") did
> not change the comment accordingly.
>
> Fixes: b6fb0df12db6 ("RDS/IB: Make ib_recv_refill return void")
> Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>
> ---
> net/rds/ib_recv.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/net/rds/ib_recv.c b/net/rds/ib_recv.c
> index b4e421aa9727..e5ce93419263 100644
> --- a/net/rds/ib_recv.c
> +++ b/net/rds/ib_recv.c
> @@ -376,8 +376,6 @@ static void release_refill(struct rds_connection *conn)
> * This tries to allocate and post unused work requests after making sure that
> * they have all the allocations they need to queue received fragments into
> * sockets.
> - *
> - * -1 is returned if posting fails due to temporary resource exhaustion.
> */
> void rds_ib_recv_refill(struct rds_connection *conn, int prefill, gfp_t gfp)
> {
>
Yep. Thanks !!
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.ccom>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net/rds: void function cannot return -1
2018-07-16 13:00 [PATCH] net/rds: void function cannot return -1 Håkon Bugge
2018-07-16 16:29 ` Santosh Shilimkar
@ 2018-07-18 5:44 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-07-18 5:44 UTC (permalink / raw)
To: Haakon.Bugge
Cc: santosh.shilimkar, netdev, linux-rdma, rds-devel, linux-kernel
From: Håkon Bugge <Haakon.Bugge@oracle.com>
Date: Mon, 16 Jul 2018 15:00:09 +0200
> Commit b6fb0df12db6 ("RDS/IB: Make ib_recv_refill return void") did
> not change the comment accordingly.
>
> Fixes: b6fb0df12db6 ("RDS/IB: Make ib_recv_refill return void")
> Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-18 5:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-16 13:00 [PATCH] net/rds: void function cannot return -1 Håkon Bugge
2018-07-16 16:29 ` Santosh Shilimkar
2018-07-18 5:44 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).