From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Cochran Subject: Re: [PATCH] ptp: fix missing break in switch Date: Tue, 17 Jul 2018 20:46:00 -0700 Message-ID: <20180718034600.lw6qet25kkpqquam@localhost> References: <20180718011733.GA27872@embeddedor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Stefan =?iso-8859-1?Q?S=F8rensen?= , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: "Gustavo A. R. Silva" Return-path: Content-Disposition: inline In-Reply-To: <20180718011733.GA27872@embeddedor.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Tue, Jul 17, 2018 at 08:17:33PM -0500, Gustavo A. R. Silva wrote: > It seems that a *break* is missing in order to avoid falling through > to the default case. Otherwise, checking *chan* makes no sense. Good catch. Acked-by: Richard Cochran