Netdev List
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: alexei.starovoitov@gmail.com
Cc: jakub.kicinski@netronome.com, netdev@vger.kernel.org,
	Daniel Borkmann <daniel@iogearbox.net>
Subject: [PATCH bpf-next] bpf: show in bpftool map overview whether btf is available
Date: Wed, 18 Jul 2018 11:19:42 +0200	[thread overview]
Message-ID: <20180718091942.2963-1-daniel@iogearbox.net> (raw)

For a quick overview in 'bpftool map' display 'btf' if it's
available for the dump for a specific map:

  # bpftool map list
  11: array  flags 0x0  btf
          key 4B  value 20B  max_entries 40  memlock 4096B

  # bpftool --json --pretty map list
  [{
          "id": 11,
          "type": "array",
          "flags": 0,
          "btf_available": true,
          "bytes_key": 4,
          "bytes_value": 20,
          "max_entries": 40,
          "bytes_memlock": 4096
      }
  ]

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
---
 tools/bpf/bpftool/map.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tools/bpf/bpftool/map.c b/tools/bpf/bpftool/map.c
index 9c81918..2cc4741 100644
--- a/tools/bpf/bpftool/map.c
+++ b/tools/bpf/bpftool/map.c
@@ -490,6 +490,8 @@ static int show_map_close_json(int fd, struct bpf_map_info *info)
 
 	jsonw_name(json_wtr, "flags");
 	jsonw_printf(json_wtr, "%d", info->map_flags);
+	jsonw_name(json_wtr, "btf_available");
+	jsonw_bool(json_wtr, info->btf_key_type_id && info->btf_value_type_id);
 
 	print_dev_json(info->ifindex, info->netns_dev, info->netns_ino);
 
@@ -535,6 +537,8 @@ static int show_map_close_plain(int fd, struct bpf_map_info *info)
 		printf("name %s  ", info->name);
 
 	printf("flags 0x%x", info->map_flags);
+	if (info->btf_key_type_id && info->btf_value_type_id)
+		printf("  btf");
 	print_dev_plain(info->ifindex, info->netns_dev, info->netns_ino);
 	printf("\n");
 	printf("\tkey %uB  value %uB  max_entries %u",
-- 
2.9.5

             reply	other threads:[~2018-07-18  9:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-18  9:19 Daniel Borkmann [this message]
2018-07-18 16:35 ` [PATCH bpf-next] bpf: show in bpftool map overview whether btf is available Martin KaFai Lau
2018-07-18 18:08 ` Jakub Kicinski
2018-07-19 15:45   ` Daniel Borkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180718091942.2963-1-daniel@iogearbox.net \
    --to=daniel@iogearbox.net \
    --cc=alexei.starovoitov@gmail.com \
    --cc=jakub.kicinski@netronome.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox