From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Chevallier Subject: Re: [PATCH] net: mvpp2: debugfs: fix incorrect bitwise operator Date: Wed, 18 Jul 2018 16:09:39 +0200 Message-ID: <20180718160939.5650559b@bootlin.com> References: <20180718130846.GA5380@embeddedor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: "Gustavo A. R. Silva" Return-path: In-Reply-To: <20180718130846.GA5380@embeddedor.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hi Gustavo, On Wed, 18 Jul 2018 08:08:46 -0500 "Gustavo A. R. Silva" wrote: >The use of the | operator always leads to true, which looks rather >suspect in this case. > >Fix this by using & instead. > Acked-by: Maxime Chevallier Good catch, thanks. Maxime