From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [PATCH net-next] net: rename ndo_setup_tc to ndo_setup_offload
Date: Wed, 18 Jul 2018 18:34:19 +0200
Message-ID: <20180718163419.ftwd3zn4cauc4gwa@salvia>
References: <20180718161404.24198-1-pablo@netfilter.org>
 <20180718163054.GF2184@nanopsycho.orion>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netdev@vger.kernel.org, thomas.lendacky@amd.com,
        f.fainelli@gmail.com, ariel.elior@cavium.com,
        michael.chan@broadcom.com, santosh@chelsio.com,
        madalin.bucur@nxp.com, yisen.zhuang@huawei.com,
        salil.mehta@huawei.com, jeffrey.t.kirsher@intel.com,
        tariqt@mellanox.com, saeedm@mellanox.com, jiri@mellanox.com,
        idosch@mellanox.com, ganeshgr@chelsio.com,
        jakub.kicinski@netronome.com, linux-net-drivers@solarflare.com,
        peppe.cavallaro@st.com, alexandre.torgue@st.com,
        joabreu@synopsys.com, grygorii.strashko@ti.com, andrew@lunn.ch,
        vivien.didelot@savoirfairelinux.com
To: Jiri Pirko <jiri@resnulli.us>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail.us.es ([193.147.175.20]:56798 "EHLO mail.us.es"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1731605AbeGRRNF (ORCPT <rfc822;netdev@vger.kernel.org>);
        Wed, 18 Jul 2018 13:13:05 -0400
Received: from antivirus1-rhel7.int (unknown [192.168.2.11])
        by mail.us.es (Postfix) with ESMTP id D36A349D85
        for <netdev@vger.kernel.org>; Wed, 18 Jul 2018 18:32:27 +0200 (CEST)
Received: from antivirus1-rhel7.int (localhost [127.0.0.1])
        by antivirus1-rhel7.int (Postfix) with ESMTP id BC8B7DA4C7
        for <netdev@vger.kernel.org>; Wed, 18 Jul 2018 18:32:27 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <20180718163054.GF2184@nanopsycho.orion>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, Jul 18, 2018 at 06:30:54PM +0200, Jiri Pirko wrote:
> Wed, Jul 18, 2018 at 06:14:04PM CEST, pablo@netfilter.org wrote:
> >One of the recurring complaints is that we do not have, as a driver
> >writer, a central location from which we would be fed offloading rules
> >into a NIC. This was brought up again during Netconf'18 in Boston.
> >
> >This patch just renames ndo_setup_tc to ndo_setup_offload as a very
> >early initial work to prepare for follow up patches that discuss/propose
> >unified flow representation for the existing offload programming APIs:
> >ethtool_rxnfc, cls_flower, cls_u32 and (probably, not yet upstream)
> >conntrack.
> >
> >Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
> 
> Acked-by: Jiri Pirko <jiri@mellanox.com>
> 
> It would make sense to also rename following enum:
> enum tc_setup_type {
>         TC_SETUP_QDISC_MQPRIO,
>         TC_SETUP_CLSU32,
>         TC_SETUP_CLSFLOWER,
>         TC_SETUP_CLSMATCHALL,
>         TC_SETUP_CLSBPF,
>         TC_SETUP_BLOCK,
>         TC_SETUP_QDISC_CBS,
>         TC_SETUP_QDISC_RED,
>         TC_SETUP_QDISC_PRIO,
>         TC_SETUP_QDISC_MQ,
>         TC_SETUP_QDISC_ETF,
> };
> 
> Maybe "enum setup_offload_type" and "SETUP_OFFLOAD_TC_*"?
> 
> Could you please do it in a follow-up?

Yes sure, I will do asap. Thanks Jiri.