From: Andrew Lunn <andrew@lunn.ch>
To: Bryan.Whitehead@microchip.com
Cc: davem@davemloft.net, netdev@vger.kernel.org,
UNGLinuxDriver@microchip.com
Subject: Re: [PATCH v3 net-next 6/8] lan743x: Add power management support
Date: Thu, 19 Jul 2018 00:43:57 +0200 [thread overview]
Message-ID: <20180718224357.GA25710@lunn.ch> (raw)
In-Reply-To: <90A7E81AE28BAE4CBDDB3B35F187D2644073B198@CHN-SV-EXMX02.mchp-main.com>
> Hi Andrew,
> I assumed that "supported" means that it is supported by both the phy and mac driver, which is why I used the AND operator.
> Am I mistaken? Is WAKE_MAGICSECURE a special case not requiring mac driver support?
It depends on the hardware designs, but in some designs, the PHY can
do WOL, without the MAC involved. When a WoL condition happens, it
triggers an interrupt, or blinks an LED which is also connected to the
power supply etc. And if the PHY is doing WoL, you can shut down the
MAC, save more power.
Look at some of the PHY drivers, at803x, dp83822, dp83tc811, marvell,
and mscc all support some sort of WoL.
Ideally, you want to offer the superset of both PHY WoL and MAC WoL.
Andrew
next prev parent reply other threads:[~2018-07-18 23:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 21:04 [PATCH v3 net-next 0/8] lan743x: Add features to lan743x driver Bryan Whitehead
2018-07-18 21:04 ` [PATCH v3 net-next 1/8] lan743x: Add support for ethtool get_drvinfo Bryan Whitehead
2018-07-18 21:04 ` [PATCH v3 net-next 2/8] lan743x: Add support for ethtool link settings Bryan Whitehead
2018-07-18 21:04 ` [PATCH v3 net-next 3/8] lan743x: Add support for ethtool statistics Bryan Whitehead
2018-07-18 21:04 ` [PATCH v3 net-next 4/8] lan743x: Add support for ethtool message level Bryan Whitehead
2018-07-18 21:04 ` [PATCH v3 net-next 5/8] lan743x: Add support for ethtool eeprom access Bryan Whitehead
2018-07-18 21:04 ` [PATCH v3 net-next 6/8] lan743x: Add power management support Bryan Whitehead
2018-07-18 21:35 ` Andrew Lunn
2018-07-18 21:55 ` Bryan.Whitehead
2018-07-18 22:43 ` Andrew Lunn [this message]
2018-07-18 22:46 ` Bryan.Whitehead
2018-07-18 22:15 ` David Miller
2018-07-18 22:17 ` David Miller
2018-07-18 22:36 ` Bryan.Whitehead
2018-07-18 21:04 ` [PATCH v3 net-next 7/8] lan743x: Add EEE support Bryan Whitehead
2018-07-18 21:46 ` Andrew Lunn
2018-07-18 21:04 ` [PATCH v3 net-next 8/8] lan743x: Add RSS support Bryan Whitehead
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180718224357.GA25710@lunn.ch \
--to=andrew@lunn.ch \
--cc=Bryan.Whitehead@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).