From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH v3 net-next 6/8] lan743x: Add power management support
Date: Thu, 19 Jul 2018 00:43:57 +0200
Message-ID: <20180718224357.GA25710@lunn.ch>
References: <1531947878-9758-1-git-send-email-Bryan.Whitehead@microchip.com>
 <1531947878-9758-7-git-send-email-Bryan.Whitehead@microchip.com>
 <20180718213513.GA23800@lunn.ch>
 <90A7E81AE28BAE4CBDDB3B35F187D2644073B198@CHN-SV-EXMX02.mchp-main.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: davem@davemloft.net, netdev@vger.kernel.org,
        UNGLinuxDriver@microchip.com
To: Bryan.Whitehead@microchip.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:39240 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1729654AbeGRXYE (ORCPT <rfc822;netdev@vger.kernel.org>);
        Wed, 18 Jul 2018 19:24:04 -0400
Content-Disposition: inline
In-Reply-To: <90A7E81AE28BAE4CBDDB3B35F187D2644073B198@CHN-SV-EXMX02.mchp-main.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

> Hi Andrew,

> I assumed that "supported" means that it is supported by both the phy and mac driver, which is why I used the AND operator.
> Am I mistaken? Is WAKE_MAGICSECURE a special case not requiring mac driver support?

It depends on the hardware designs, but in some designs, the PHY can
do WOL, without the MAC involved. When a WoL condition happens, it
triggers an interrupt, or blinks an LED which is also connected to the
power supply etc. And if the PHY is doing WoL, you can shut down the
MAC, save more power.

Look at some of the PHY drivers, at803x, dp83822, dp83tc811, marvell,
and mscc all support some sort of WoL.

Ideally, you want to offer the superset of both PHY WoL and MAC WoL.

    Andrew