From: David Miller <davem@davemloft.net>
To: penguin-kernel@I-love.SAKURA.ne.jp
Cc: sameo@linux.intel.com, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org,
syzbot+d29d18215e477cfbfbdd@syzkaller.appspotmail.com
Subject: Re: [PATCH] net/nfc: Avoid stalls when nfc_alloc_send_skb() returned NULL.
Date: Thu, 19 Jul 2018 02:52:24 +0900 (KST) [thread overview]
Message-ID: <20180719.025224.724580559198605486.davem@davemloft.net> (raw)
In-Reply-To: <1531907847-3500-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp>
From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Date: Wed, 18 Jul 2018 18:57:27 +0900
> syzbot is reporting stalls at nfc_llcp_send_ui_frame() [1]. This is
> because nfc_llcp_send_ui_frame() is retrying the loop without any delay
> when nonblocking nfc_alloc_send_skb() returned NULL.
>
> Since there is no need to use MSG_DONTWAIT if we retry until
> sock_alloc_send_pskb() succeeds, let's use blocking call.
> Also, in case an unexpected error occurred, let's break the loop
> if blocking nfc_alloc_send_skb() failed.
>
> [1] https://syzkaller.appspot.com/bug?id=4a131cc571c3733e0eff6bc673f4e36ae48f19c6
>
> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> Reported-by: syzbot <syzbot+d29d18215e477cfbfbdd@syzkaller.appspotmail.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2018-07-18 18:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 9:57 [PATCH] net/nfc: Avoid stalls when nfc_alloc_send_skb() returned NULL Tetsuo Handa
2018-07-18 17:52 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180719.025224.724580559198605486.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=sameo@linux.intel.com \
--cc=syzbot+d29d18215e477cfbfbdd@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox