From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [RFC PATCH 3/3] net: macb: add support for padding and fcs
 computation
Date: Thu, 19 Jul 2018 02:54:23 +0900 (KST)
Message-ID: <20180719.025423.1409264262161292298.davem@davemloft.net>
References: <1531918689-22658-1-git-send-email-claudiu.beznea@microchip.com>
        <1531918689-22658-4-git-send-email-claudiu.beznea@microchip.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: nicolas.ferre@microchip.com, netdev@vger.kernel.org,
        jennifer.dahm@ni.com, nathan.sullivan@ni.com
To: claudiu.beznea@microchip.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([23.128.96.9]:40530 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1730897AbeGRSdY (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 18 Jul 2018 14:33:24 -0400
In-Reply-To: <1531918689-22658-4-git-send-email-claudiu.beznea@microchip.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Claudiu Beznea <claudiu.beznea@microchip.com>
Date: Wed, 18 Jul 2018 15:58:09 +0300

>  
> +static int macb_pad_and_fcs(struct sk_buff **skb, struct net_device *ndev)
> +{
> +	struct sk_buff *nskb;
> +	int padlen = ETH_ZLEN - (*skb)->len;
> +	int headroom = skb_headroom(*skb);
> +	int tailroom = skb_tailroom(*skb);
> +	bool cloned = skb_cloned(*skb) || skb_header_cloned(*skb);
> +	u32 fcs;

Please keep local variable ordered from longest to shortest line
(ie. reverse christmas tree format).

Thank you.