From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] net: usb: asix: replace mii_nway_restart in resume path Date: Thu, 19 Jul 2018 05:43:50 +0900 (KST) Message-ID: <20180719.054350.891466987638140875.davem@davemloft.net> References: <20180717111709.8598-1-lynxis@fe80.eu> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: linux-usb@vger.kernel.org, robert.foss@collabora.com, netdev@vger.kernel.org To: lynxis@fe80.eu Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:43212 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730403AbeGRVX1 (ORCPT ); Wed, 18 Jul 2018 17:23:27 -0400 In-Reply-To: <20180717111709.8598-1-lynxis@fe80.eu> Sender: netdev-owner@vger.kernel.org List-ID: From: Alexander Couzens Date: Tue, 17 Jul 2018 13:17:09 +0200 > mii_nway_restart is not pm aware which results in a rtnl deadlock. > Implement mii_nway_restart manual by setting BMCR_ANRESTART if > BMCR_ANENABLE is set. > > To reproduce: > * plug an asix based usb network interface > * wait until the device enters PM (~5 sec) > * `ip link set eth1 up` will never return > > Fixes: d9fe64e51114 ("net: asix: Add in_pm parameter") > Signed-off-by: Alexander Couzens Applied and queued up for -stable, thank you.