From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] ipv6: fix useless rol32 call on hash Date: Thu, 19 Jul 2018 07:11:57 +0900 (KST) Message-ID: <20180719.071157.192880975693614441.davem@davemloft.net> References: <20180717161239.30782-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org To: colin.king@canonical.com Return-path: In-Reply-To: <20180717161239.30782-1-colin.king@canonical.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Colin King Date: Tue, 17 Jul 2018 17:12:39 +0100 > From: Colin Ian King > > The rol32 call is currently rotating hash but the rol'd value is > being discarded. I believe the current code is incorrect and hash > should be assigned the rotated value returned from rol32. > > Thanks to David Lebrun for spotting this. > > Signed-off-by: Colin Ian King Also applied and queued up for -stable, thanks.