From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] ptp: fix missing break in switch Date: Thu, 19 Jul 2018 07:26:08 +0900 (KST) Message-ID: <20180719.072608.944784986385146557.davem@davemloft.net> References: <20180718011733.GA27872@embeddedor.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: stefan.sorensen@spectralink.com, richardcochran@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: gustavo@embeddedor.com Return-path: In-Reply-To: <20180718011733.GA27872@embeddedor.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: "Gustavo A. R. Silva" Date: Tue, 17 Jul 2018 20:17:33 -0500 > It seems that a *break* is missing in order to avoid falling through > to the default case. Otherwise, checking *chan* makes no sense. > > Fixes: 72df7a7244c0 ("ptp: Allow reassigning calibration pin function") > Signed-off-by: Gustavo A. R. Silva Applied and queued up for -stable, thank you.