From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 1/1] net-next/hinic: fix a problem in hinic_xmit_frame() Date: Thu, 19 Jul 2018 23:28:24 -0700 (PDT) Message-ID: <20180719.232824.2267856623115325271.davem@davemloft.net> References: <20180718043318.3211-1-zhaochen6@huawei.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, aviad.krawczyk@huawei.com, tony.qu@huawei.com, yin.yinshi@huawei.com, luoshaokai@huawei.com To: zhaochen6@huawei.com Return-path: In-Reply-To: <20180718043318.3211-1-zhaochen6@huawei.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Zhao Chen Date: Wed, 18 Jul 2018 00:33:18 -0400 > The calculation of "wqe_size" is not correct when the tx queue is busy in > hinic_xmit_frame(). > > When there are no free WQEs, the tx flow will unmap the skb buffer, then > ring the doobell for the pending packets. But the "wqe_size" which used > to calculate the doorbell address is not correct. The wqe size should be > cleared to 0, otherwise, it will cause a doorbell error. > > This patch fixes the problem. > > Reported-by: Zhou Wang > Signed-off-by: Zhao Chen Applied and queued up for -stable.