From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [PATCH net-next,v2] net: rename ndo_setup_tc to ndo_setup_offload
Date: Thu, 19 Jul 2018 22:52:12 +0200
Message-ID: <20180719205212.f4invmtqvtcjzuid@salvia>
References: <20180719001114.4883-1-pablo@netfilter.org>
 <CAKgT0UcTihfkgzO=AZ=J_hS-3gg_wjMYr+kJGAWobQ_Wkdfp9g@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Netdev <netdev@vger.kernel.org>, Jiri Pirko <jiri@resnulli.us>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Ariel Elior <ariel.elior@cavium.com>,
        Michael Chan <michael.chan@broadcom.com>,
        Santosh Raspatur <santosh@chelsio.com>, madalin.bucur@nxp.com,
        yisen.zhuang@huawei.com, salil.mehta@huawei.com,
        Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
        Tariq Toukan <tariqt@mellanox.com>,
        Saeed Mahameed <saeedm@mellanox.com>,
        Jiri Pirko <jiri@mellanox.com>,
        Ido Schimmel <idosch@mellanox.com>,
        Ganesh Goudar <ganeshgr@chelsio.com>,
        Jakub Kicinski <jakub.kicinski@netronome.com>,
        linux-net-drivers@solarflare.com, peppe.cavallaro@st.com,
        alexandre.torgue@st.com, joabreu@synopsys.com,
        grygorii.strashko@ti.com, Andrew Lunn <andrew@lunn.ch>,
To: Alexander Duyck <alexander.duyck@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail.us.es ([193.147.175.20]:40526 "EHLO mail.us.es"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727609AbeGSVhI (ORCPT <rfc822;netdev@vger.kernel.org>);
        Thu, 19 Jul 2018 17:37:08 -0400
Received: from antivirus1-rhel7.int (unknown [192.168.2.11])
        by mail.us.es (Postfix) with ESMTP id 24374FEFB8
        for <netdev@vger.kernel.org>; Thu, 19 Jul 2018 22:50:20 +0200 (CEST)
Received: from antivirus1-rhel7.int (localhost [127.0.0.1])
        by antivirus1-rhel7.int (Postfix) with ESMTP id 0F955DA4D3
        for <netdev@vger.kernel.org>; Thu, 19 Jul 2018 22:50:20 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <CAKgT0UcTihfkgzO=AZ=J_hS-3gg_wjMYr+kJGAWobQ_Wkdfp9g@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, Jul 19, 2018 at 08:18:20AM -0700, Alexander Duyck wrote:
> On Wed, Jul 18, 2018 at 5:11 PM, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > One of the recurring complaints is that we do not have, as a driver
> > writer, a central location from which we would be fed offloading rules
> > into a NIC. This was brought up again during Netconf'18 in Boston.
> >
> > This patch just renames ndo_setup_tc to ndo_setup_offload as a very
> > early initial work to prepare for follow up patch that discuss unified
> > flow representation for the existing offload programming APIs.
> >
> > Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
> > Acked-by: Jiri Pirko <jiri@mellanox.com>
> > Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> 
> One request I would have here is to not bother updating the individual
> driver function names. For now I would say we could leave the
> "_setup_tc" in the naming of the driver functions itself and just
> update the name of the net device operation. Renaming the driver
> functions just adds unnecessary overhead and complexity to the patch
> and will make it more difficult to maintain. When we get around to
> adding additional functionality that relates to the rename we could
> address renaming the function on a per driver basis in the future.

Plan was to follow up patch will rename enum tc_setup_type too:

https://marc.info/?l=linux-netdev&m=153193158512556&w=2

that will result in more renames in the driver side.

I would expect this will happen sooner or later, and out of tree
patches will end up needing a rebase sooner or later, if that is the
concern.