From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [net-next 1/1] tipc: make link capability update thread safe
Date: Fri, 20 Jul 2018 12:36:41 -0700 (PDT)
Message-ID: <20180720.123641.478242247443729049.davem@davemloft.net>
References: <1531936206-3118-1-git-send-email-jon.maloy@ericsson.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, gordan.mihaljevic@dektech.com.au,
        tung.q.nguyen@dektech.com.au, hoang.h.le@dektech.com.au,
        canh.d.luu@dektech.com.au, ying.xue@windriver.com,
        tipc-discussion@lists.sourceforge.net
To: jon.maloy@ericsson.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([23.128.96.9]:53822 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S2388373AbeGTU0Y (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 20 Jul 2018 16:26:24 -0400
In-Reply-To: <1531936206-3118-1-git-send-email-jon.maloy@ericsson.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Jon Maloy <jon.maloy@ericsson.com>
Date: Wed, 18 Jul 2018 19:50:06 +0200

> The commit referred to below introduced an update of the link
> capabilities field that is not safe. Given the recently added
> feature to remove idle node and link items after 5 minutes, there
> is a small risk that the update will happen at the very moment the
> targeted link is being removed. To avoid this we have to perform
> the update inside the node item's write lock protection.
> 
> Fixes: 9012de508956 ("tipc: add sequence number check for link STATE messages")
> Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>

Applied, thanks Jon.