From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH net-next 1/2] net: bridge: add support for raw sysfs port options Date: Fri, 20 Jul 2018 10:20:44 -0700 Message-ID: <20180720102044.16b92166@xeon-e3> References: <20180720144826.29892-1-nikolay@cumulusnetworks.com> <20180720144826.29892-2-nikolay@cumulusnetworks.com> <20180720085725.6dc1743d@xeon-e3> <8D6C03E0-6596-4B5B-9B6C-5684B5DFE148@cumulusnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com, bridge@lists.linux-foundation.org, wkok@cumulusnetworks.com, anuradhak@cumulusnetworks.com, davem@davemloft.net To: Nikolay Aleksandrov Return-path: In-Reply-To: <8D6C03E0-6596-4B5B-9B6C-5684B5DFE148@cumulusnetworks.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bridge-bounces@lists.linux-foundation.org Errors-To: bridge-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org On Fri, 20 Jul 2018 20:14:43 +0300 Nikolay Aleksandrov wrote: > >Casting away the const on the buf variable is going to cause warnings > >and should not be necessary. > > > > It doesn't when it's casted like that, the new line is changed to null byte so we need to drop > the const. Then change store function to take a char *?