From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH net-next 1/2] net: bridge: add support for raw sysfs
 port options
Date: Fri, 20 Jul 2018 14:14:22 -0700
Message-ID: <20180720141422.34e83e3f@xeon-e3>
References: <20180720144826.29892-1-nikolay@cumulusnetworks.com>
        <20180720144826.29892-2-nikolay@cumulusnetworks.com>
        <20180720085725.6dc1743d@xeon-e3>
        <8D6C03E0-6596-4B5B-9B6C-5684B5DFE148@cumulusnetworks.com>
        <20180720102044.16b92166@xeon-e3>
        <708CD30E-1F32-4769-A1C1-FE77762FA172@cumulusnetworks.com>
        <C6B4C1AB-7991-45B3-9649-CC4A36D878A8@cumulusnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com,
        anuradhak@cumulusnetworks.com, bridge@lists.linux-foundation.org,
        wkok@cumulusnetworks.com, davem@davemloft.net
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl0-f65.google.com ([209.85.160.65]:44530 "EHLO
        mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1728167AbeGTWE1 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 20 Jul 2018 18:04:27 -0400
Received: by mail-pl0-f65.google.com with SMTP id m16-v6so5675528pls.11
        for <netdev@vger.kernel.org>; Fri, 20 Jul 2018 14:14:25 -0700 (PDT)
In-Reply-To: <C6B4C1AB-7991-45B3-9649-CC4A36D878A8@cumulusnetworks.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Fri, 20 Jul 2018 20:47:26 +0300
Nikolay Aleksandrov <nikolay@cumulusnetworks.com> wrote:

> On July 20, 2018 8:26:36 PM GMT+03:00, Nikolay Aleksandrov <nikolay@cumulusnetworks.com> wrote:
> >On July 20, 2018 8:20:44 PM GMT+03:00, Stephen Hemminger
> ><stephen@networkplumber.org> wrote:  
> >>On Fri, 20 Jul 2018 20:14:43 +0300
> >>Nikolay Aleksandrov <nikolay@cumulusnetworks.com> wrote:
> >>  
> >>> >Casting away the const on the buf variable is going to cause  
> >>warnings  
> >>> >and should not be necessary.
> >>> >    
> >>> 
> >>> It doesn't when it's casted like that, the new line is changed to  
> >>null byte so we need to drop   
> >>> the const.  
> >>
> >>Then change store function to take a char *?  
> >
> >Sure, will do.  
> 
> Acrually I can't change sysfs_ops store prototype. 
> That is the reason the bond also casts the ptr.
> 
> 
> 

Ok.