From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v2 bpf-next] bpfilter: Fix mismatch in function argument types Date: Sat, 21 Jul 2018 16:21:51 -0700 (PDT) Message-ID: <20180721.162151.2056706808480433302.davem@davemloft.net> References: <20180719075659.9800-1-yuehaibing@huawei.com> <20180719154817.ycwupljsx4ghkhom@kafai-mbp.dhcp.thefacebook.com> <9c9f981b-7d1e-1bb2-6771-727fc762c7c5@iogearbox.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: kafai@fb.com, yuehaibing@huawei.com, ast@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org To: daniel@iogearbox.net Return-path: In-Reply-To: <9c9f981b-7d1e-1bb2-6771-727fc762c7c5@iogearbox.net> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Daniel Borkmann Date: Thu, 19 Jul 2018 17:51:41 +0200 > On 07/19/2018 05:48 PM, Martin KaFai Lau wrote: >> On Thu, Jul 19, 2018 at 03:56:59PM +0800, YueHaibing wrote: >>> Fix following warning: >>> net/ipv4/bpfilter/sockopt.c:28:5: error: symbol 'bpfilter_ip_set_sockopt' redeclared with different type >>> net/ipv4/bpfilter/sockopt.c:34:5: error: symbol 'bpfilter_ip_get_sockopt' redeclared with different type >>> >>> Signed-off-by: YueHaibing >> LGTM. Missing a Fixes tag though. >> >> Fixes: d2ba09c17a06 ("net: add skeleton of bpfilter kernel module") >> Acked-by: Martin KaFai Lau > > (Should go to -net tree.) > > Acked-by: Daniel Borkmann Applied.