From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] net/ipv6: Fix linklocal to global address with VRF Date: Sat, 21 Jul 2018 19:32:36 -0700 (PDT) Message-ID: <20180721.193236.2034280150310979114.davem@davemloft.net> References: <20180719194118.25346-1-dsahern@kernel.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, dsahern@gmail.com To: dsahern@kernel.org Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:48326 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728220AbeGVD1c (ORCPT ); Sat, 21 Jul 2018 23:27:32 -0400 In-Reply-To: <20180719194118.25346-1-dsahern@kernel.org> Sender: netdev-owner@vger.kernel.org List-ID: From: dsahern@kernel.org Date: Thu, 19 Jul 2018 12:41:18 -0700 > From: David Ahern > > Example setup: > host: ip -6 addr add dev eth1 2001:db8:104::4 > where eth1 is enslaved to a VRF > > switch: ip -6 ro add 2001:db8:104::4/128 dev br1 > where br1 only has an LLA > > ping6 2001:db8:104::4 > ssh 2001:db8:104::4 > > (NOTE: UDP works fine if the PKTINFO has the address set to the global > address and ifindex is set to the index of eth1 with a destination an > LLA). > > For ICMP, icmp6_iif needs to be updated to check if skb->dev is an > L3 master. If it is then return the ifindex from rt6i_idev similar > to what is done for loopback. > > For TCP, restore the original tcp_v6_iif definition which is needed in > most places and add a new tcp_v6_iif_l3_slave that considers the > l3_slave variability. This latter check is only needed for socket > lookups. > > Fixes: 9ff74384600a ("net: vrf: Handle ipv6 multicast and link-local addresses") > Signed-off-by: David Ahern Applied and queued up for -stable. > Dave: I can look at the backports to stable if needed. Please do, that will help me a lot.