From: David Miller <davem@davemloft.net>
To: liuhangbin@gmail.com
Cc: netdev@vger.kernel.org, xiyou.wangcong@gmail.com,
hideaki.yoshifuji@miraclelinux.com, daniel@iogearbox.net
Subject: Re: [PATCH net] multicast: do not restore deleted record source filter mode to new one
Date: Sat, 21 Jul 2018 22:59:32 -0700 (PDT) [thread overview]
Message-ID: <20180721.225932.2009460010852969132.davem@davemloft.net> (raw)
In-Reply-To: <1532066667-11389-1-git-send-email-liuhangbin@gmail.com>
From: Hangbin Liu <liuhangbin@gmail.com>
Date: Fri, 20 Jul 2018 14:04:27 +0800
> There are two scenarios that we will restore deleted records. The first is
> when device down and up(or unmap/remap). In this scenario the new filter
> mode is same with previous one. Because we get it from in_dev->mc_list and
> we do not touch it during device down and up.
>
> The other scenario is when a new socket join a group which was just delete
> and not finish sending status reports. In this scenario, we should use the
> current filter mode instead of restore old one. Here are 4 cases in total.
>
> old_socket new_socket before_fix after_fix
> IN(A) IN(A) ALLOW(A) ALLOW(A)
> IN(A) EX( ) TO_IN( ) TO_EX( )
> EX( ) IN(A) TO_EX( ) ALLOW(A)
> EX( ) EX( ) TO_EX( ) TO_EX( )
>
> Fixes: 24803f38a5c0b (igmp: do not remove igmp souce list info when set link down)
> Fixes: 1666d49e1d416 (mld: do not remove mld souce list info when set link down)
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Applied and queued up for -stable, thank you.
prev parent reply other threads:[~2018-07-22 6:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 6:04 [PATCH net] multicast: do not restore deleted record source filter mode to new one Hangbin Liu
2018-07-22 5:59 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180721.225932.2009460010852969132.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=daniel@iogearbox.net \
--cc=hideaki.yoshifuji@miraclelinux.com \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).