From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net 0/4] vxlan: fix default fdb entry user-space notify ordering/race Date: Sun, 22 Jul 2018 10:54:26 -0700 (PDT) Message-ID: <20180722.105426.1606927541503763499.davem@davemloft.net> References: <1532118064-45513-1-git-send-email-roopa@cumulusnetworks.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: roopa@cumulusnetworks.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:57514 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730076AbeGVSvz (ORCPT ); Sun, 22 Jul 2018 14:51:55 -0400 In-Reply-To: <1532118064-45513-1-git-send-email-roopa@cumulusnetworks.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Roopa Prabhu Date: Fri, 20 Jul 2018 13:21:00 -0700 > From: Roopa Prabhu > > Problem: > In vxlan_newlink, a default fdb entry is added before register_netdev. > The default fdb creation function notifies user-space of the > fdb entry on the vxlan device which user-space does not know about yet. > (RTM_NEWNEIGH goes before RTM_NEWLINK for the same ifindex). > > This series fixes the user-space netlink notification ordering issue > with the following changes: > - decouple fdb notify from fdb create. > - Move fdb notify after register_netdev. > - modify rtnl_configure_link to allow configuring a link early. > - Call rtnl_configure_link in vxlan newlink handler to notify > userspace about the newlink before fdb notify and > hence avoiding the user-space race. > > Fixes: afbd8bae9c79 ("vxlan: add implicit fdb entry for default destination") > Signed-off-by: Roopa Prabhu Series applied and queued up for -stable, thanks Roopa.