From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] nfp: flower: ensure dead neighbour entries are not offloaded Date: Sun, 22 Jul 2018 10:56:10 -0700 (PDT) Message-ID: <20180722.105610.1256328839114580321.davem@davemloft.net> References: <20180721040754.22577-1-jakub.kicinski@netronome.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: oss-drivers@netronome.com, netdev@vger.kernel.org, john.hurley@netronome.com To: jakub.kicinski@netronome.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:57526 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729826AbeGVSxk (ORCPT ); Sun, 22 Jul 2018 14:53:40 -0400 In-Reply-To: <20180721040754.22577-1-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Jakub Kicinski Date: Fri, 20 Jul 2018 21:07:54 -0700 > From: John Hurley > > Previously only the neighbour state was checked to decide if an offloaded > entry should be removed. However, there can be situations when the entry > is dead but still marked as valid. This can lead to dead entries not > being removed from fw tables or even incorrect data being added. > > Check the entry dead bit before deciding if it should be added to or > removed from fw neighbour tables. > > Fixes: 8e6a9046b66a ("nfp: flower vxlan neighbour offload") > Signed-off-by: John Hurley > Reviewed-by: Jakub Kicinski Patch applied and queued up for -stable, thanks Jakub.