From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH net-next 0/9] TX used ring batched updating for vhost
Date: Sun, 22 Jul 2018 17:37:05 +0300 [thread overview]
Message-ID: <20180722173622-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <1532045721-4958-1-git-send-email-jasowang@redhat.com>
On Fri, Jul 20, 2018 at 08:15:12AM +0800, Jason Wang wrote:
> Hi:
>
> This series implement batch updating of used ring for TX. This help to
> reduce the cache contention on used ring. The idea is first split
> datacopy path from zerocopy, and do only batching for datacopy. This
> is because zercopy had already supported its own batching.
>
> TX PPS was increased 25.8% and Netperf TCP does not show obvious
> differences.
>
> The split of datapath will also be helpful for future implementation
> like in order completion.
>
> Please review.
>
> Thanks
Acked-by: Michael S. Tsirkin <mst@redhat.com>
I'm very happy with the split, the mixed data path became hard to
maintain.
> Jason Wang (9):
> vhost_net: drop unnecessary parameter
> vhost_net: introduce helper to initialize tx iov iter
> vhost_net: introduce vhost_exceeds_weight()
> vhost_net: introduce get_tx_bufs()
> vhost_net: introduce tx_can_batch()
> vhost_net: split out datacopy logic
> vhost_net: rename vhost_rx_signal_used() to vhost_net_signal_used()
> vhost_net: rename VHOST_RX_BATCH to VHOST_NET_BATCH
> vhost_net: batch update used ring for datacopy TX
>
> drivers/vhost/net.c | 249 +++++++++++++++++++++++++++++++++++++---------------
> 1 file changed, 179 insertions(+), 70 deletions(-)
>
> --
> 2.7.4
next prev parent reply other threads:[~2018-07-22 14:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 0:15 [PATCH net-next 0/9] TX used ring batched updating for vhost Jason Wang
2018-07-20 0:15 ` [PATCH net-next 1/9] vhost_net: drop unnecessary parameter Jason Wang
2018-07-20 0:15 ` [PATCH net-next 2/9] vhost_net: introduce helper to initialize tx iov iter Jason Wang
2018-07-20 0:15 ` [PATCH net-next 3/9] vhost_net: introduce vhost_exceeds_weight() Jason Wang
2018-07-20 0:15 ` [PATCH net-next 4/9] vhost_net: introduce get_tx_bufs() Jason Wang
2018-07-20 0:15 ` [PATCH net-next 5/9] vhost_net: introduce tx_can_batch() Jason Wang
2018-07-20 0:15 ` [PATCH net-next 6/9] vhost_net: split out datacopy logic Jason Wang
2018-07-20 0:15 ` [PATCH net-next 7/9] vhost_net: rename vhost_rx_signal_used() to vhost_net_signal_used() Jason Wang
2018-07-20 0:15 ` [PATCH net-next 8/9] vhost_net: rename VHOST_RX_BATCH to VHOST_NET_BATCH Jason Wang
2018-07-20 0:15 ` [PATCH net-next 9/9] vhost_net: batch update used ring for datacopy TX Jason Wang
2018-07-22 4:44 ` [PATCH net-next 0/9] TX used ring batched updating for vhost David Miller
2018-07-22 14:37 ` Michael S. Tsirkin [this message]
2018-07-22 16:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180722173622-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).