From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] wan/fsl_ucc_hdlc: use IS_ERR_VALUE() to check return value of qe_muram_alloc Date: Mon, 23 Jul 2018 11:07:26 -0700 (PDT) Message-ID: <20180723.110726.835170464043859135.davem@davemloft.net> References: <20180723141233.19948-1-yuehaibing@huawei.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: qiang.zhao@nxp.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org To: yuehaibing@huawei.com Return-path: In-Reply-To: <20180723141233.19948-1-yuehaibing@huawei.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: YueHaibing Date: Mon, 23 Jul 2018 22:12:33 +0800 > qe_muram_alloc return a unsigned long integer,which should not > compared with zero. check it using IS_ERR_VALUE() to fix this. > > Fixes: c19b6d246a35 ("drivers/net: support hdlc function for QE-UCC") > Signed-off-by: YueHaibing Applied, thanks.