From: David Miller <davem@davemloft.net>
To: davejwatson@fb.com
Cc: vakul.garg@nxp.com, netdev@vger.kernel.org, borisp@mellanox.com,
aviadye@mellanox.com, doronrk@fb.com
Subject: Re: [net-next v5 3/3] net/tls: Remove redundant array allocation.
Date: Mon, 23 Jul 2018 21:41:09 -0700 (PDT) [thread overview]
Message-ID: <20180723.214109.32924668491950691.davem@davemloft.net> (raw)
In-Reply-To: <20180723163509.GA91424@davejwatson-mba.local>
From: Dave Watson <davejwatson@fb.com>
Date: Mon, 23 Jul 2018 09:35:09 -0700
> I don't think this patch is safe as-is. sgin_arr is a stack array of
> size MAX_SKB_FRAGS (+ overhead), while my read of skb_cow_data is that
> it walks the whole chain of skbs from skb->next, and can return any
> number of segments. Therefore we need to heap allocate. I think I
> copied the IPSEC code here.
Ok I see what you are saying.
So it means that, when a non-NULL sgout is passed into decrypt_skb(),
via decrypt_skb_update(), via tls_sw_recvmsg() it means that it is the
zerocopy case and you know that you only have page frags and no SKB
frag list, right?
I agree with you that this change is therefore incorrect.
next prev parent reply other threads:[~2018-07-24 5:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 16:26 [net-next v5 0/3] net/tls: Minor code cleanup patches Vakul Garg
2018-07-19 16:26 ` [net-next v5 1/3] net/tls: Use socket data_ready callback on record availability Vakul Garg
2018-07-19 16:26 ` [net-next v5 2/3] net/tls: Remove redundant variable assignments and wakeup Vakul Garg
2018-07-19 16:26 ` [net-next v5 3/3] net/tls: Remove redundant array allocation Vakul Garg
2018-07-22 2:25 ` David Miller
2018-07-23 16:35 ` Dave Watson
2018-07-24 4:41 ` David Miller [this message]
2018-07-24 4:43 ` Vakul Garg
2018-07-24 4:49 ` David Miller
2018-07-24 8:22 ` Vakul Garg
2018-07-25 21:01 ` Dave Watson
2018-07-27 9:34 ` Vakul Garg
2018-07-27 15:38 ` Dave Watson
2018-08-01 13:49 ` Vakul Garg
2018-08-01 20:52 ` Dave Watson
-- strict thread matches above, loose matches on Subject: below --
2018-07-19 16:23 [net-next v4 0/3] net/tls: Minor code cleanup patches Vakul Garg
2018-07-19 16:23 ` [net-next v5 3/3] net/tls: Remove redundant array allocation Vakul Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180723.214109.32924668491950691.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aviadye@mellanox.com \
--cc=borisp@mellanox.com \
--cc=davejwatson@fb.com \
--cc=doronrk@fb.com \
--cc=netdev@vger.kernel.org \
--cc=vakul.garg@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).