* [PATCH iproute2] devlink: CTRL_ATTR_FAMILY_ID is a u16
@ 2018-07-20 16:35 dsahern
2018-07-23 20:51 ` Stephen Hemminger
0 siblings, 1 reply; 2+ messages in thread
From: dsahern @ 2018-07-20 16:35 UTC (permalink / raw)
To: stephen, netdev; +Cc: jiri, David Ahern
From: David Ahern <dsahern@gmail.com>
CTRL_ATTR_FAMILY_ID is a u16, not a u32. Update devlink accordingly.
Fixes: a3c4b484a1edd ("add devlink tool")
Signed-off-by: David Ahern <dsahern@gmail.com>
---
devlink/mnlg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/devlink/mnlg.c b/devlink/mnlg.c
index c33c90be4414..37cc25ddf490 100644
--- a/devlink/mnlg.c
+++ b/devlink/mnlg.c
@@ -199,7 +199,7 @@ int mnlg_socket_group_add(struct mnlg_socket *nlg, const char *group_name)
nlh = __mnlg_msg_prepare(nlg, CTRL_CMD_GETFAMILY,
NLM_F_REQUEST | NLM_F_ACK, GENL_ID_CTRL, 1);
- mnl_attr_put_u32(nlh, CTRL_ATTR_FAMILY_ID, nlg->id);
+ mnl_attr_put_u16(nlh, CTRL_ATTR_FAMILY_ID, nlg->id);
err = mnlg_socket_send(nlg, nlh);
if (err < 0)
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH iproute2] devlink: CTRL_ATTR_FAMILY_ID is a u16
2018-07-20 16:35 [PATCH iproute2] devlink: CTRL_ATTR_FAMILY_ID is a u16 dsahern
@ 2018-07-23 20:51 ` Stephen Hemminger
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Hemminger @ 2018-07-23 20:51 UTC (permalink / raw)
To: dsahern; +Cc: netdev, jiri, David Ahern
On Fri, 20 Jul 2018 09:35:26 -0700
dsahern@kernel.org wrote:
> From: David Ahern <dsahern@gmail.com>
>
> CTRL_ATTR_FAMILY_ID is a u16, not a u32. Update devlink accordingly.
>
> Fixes: a3c4b484a1edd ("add devlink tool")
> Signed-off-by: David Ahern <dsahern@gmail.com>
Applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-23 21:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-20 16:35 [PATCH iproute2] devlink: CTRL_ATTR_FAMILY_ID is a u16 dsahern
2018-07-23 20:51 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).