From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [patch net-next v4 00/12] sched: introduce chain templates support with offloading to mlxsw Date: Mon, 23 Jul 2018 16:36:41 -0700 Message-ID: <20180723163641.680b66fc@cakuba.netronome.com> References: <20180723072312.4153-1-jiri@resnulli.us> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, davem@davemloft.net, jhs@mojatatu.com, xiyou.wangcong@gmail.com, simon.horman@netronome.com, john.hurley@netronome.com, dsahern@gmail.com, mlxsw@mellanox.com, sridhar.samudrala@intel.com To: Jiri Pirko Return-path: Received: from mail-qk0-f195.google.com ([209.85.220.195]:43031 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388078AbeGXAkV (ORCPT ); Mon, 23 Jul 2018 20:40:21 -0400 Received: by mail-qk0-f195.google.com with SMTP id z74-v6so1553712qkb.10 for ; Mon, 23 Jul 2018 16:36:46 -0700 (PDT) In-Reply-To: <20180723072312.4153-1-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 23 Jul 2018 09:23:03 +0200, Jiri Pirko wrote: > From: Jiri Pirko > > For the TC clsact offload these days, some of HW drivers need > to hold a magic ball. The reason is, with the first inserted rule inside > HW they need to guess what fields will be used for the matching. If > later on this guess proves to be wrong and user adds a filter with a > different field to match, there's a problem. Mlxsw resolves it now with > couple of patterns. Those try to cover as many match fields as possible. > This aproach is far from optimal, both performance-wise and scale-wise. > Also, there is a combination of filters that in certain order won't > succeed. > > Most of the time, when user inserts filters in chain, he knows right away > how the filters are going to look like - what type and option will they > have. For example, he knows that he will only insert filters of type > flower matching destination IP address. He can specify a template that > would cover all the filters in the chain. > > This patchset is providing the possibility to user to provide such > template to kernel and propagate it all the way down to device > drivers. LGTM, thanks for the changes!