From: David Miller <davem@davemloft.net>
To: vakul.garg@nxp.com
Cc: netdev@vger.kernel.org, borisp@mellanox.com,
aviadye@mellanox.com, davejwatson@fb.com
Subject: Re: [net-next v6 1/2] net/tls: Use socket data_ready callback on record availability
Date: Tue, 24 Jul 2018 13:12:35 -0700 (PDT) [thread overview]
Message-ID: <20180724.131235.814794866288330271.davem@davemloft.net> (raw)
In-Reply-To: <20180724101403.27040-2-vakul.garg@nxp.com>
From: Vakul Garg <vakul.garg@nxp.com>
Date: Tue, 24 Jul 2018 15:44:02 +0530
> On receipt of a complete tls record, use socket's saved data_ready
> callback instead of state_change callback.
>
> Signed-off-by: Vakul Garg <vakul.garg@nxp.com>
I don't think this is correct.
Here, the stream parser has given us a complete TLS record.
But we haven't decrypted this packet yet. It sits on the
stream parser's queue to be processed by tls_sw_recvmsg(),
not the saved socket's receive queue.
next prev parent reply other threads:[~2018-07-24 21:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 10:14 [net-next v6 0/2] Minor code cleanup patches Vakul Garg
2018-07-24 10:14 ` [net-next v6 1/2] net/tls: Use socket data_ready callback on record availability Vakul Garg
2018-07-24 20:12 ` David Miller [this message]
2018-07-25 5:51 ` Vakul Garg
2018-07-29 6:01 ` Vakul Garg
2018-07-29 6:17 ` David Miller
2018-07-29 6:20 ` Vakul Garg
2018-07-24 10:14 ` [net-next v6 2/2] net/tls: Remove redundant variable assignments and wakeup Vakul Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180724.131235.814794866288330271.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aviadye@mellanox.com \
--cc=borisp@mellanox.com \
--cc=davejwatson@fb.com \
--cc=netdev@vger.kernel.org \
--cc=vakul.garg@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).