From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [net-next v6 1/2] net/tls: Use socket data_ready callback on
 record availability
Date: Tue, 24 Jul 2018 13:12:35 -0700 (PDT)
Message-ID: <20180724.131235.814794866288330271.davem@davemloft.net>
References: <20180724101403.27040-1-vakul.garg@nxp.com>
        <20180724101403.27040-2-vakul.garg@nxp.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, borisp@mellanox.com, aviadye@mellanox.com,
        davejwatson@fb.com
To: vakul.garg@nxp.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([23.128.96.9]:37576 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S2388638AbeGXVVC (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 24 Jul 2018 17:21:02 -0400
In-Reply-To: <20180724101403.27040-2-vakul.garg@nxp.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Vakul Garg <vakul.garg@nxp.com>
Date: Tue, 24 Jul 2018 15:44:02 +0530

> On receipt of a complete tls record, use socket's saved data_ready
> callback instead of state_change callback.
> 
> Signed-off-by: Vakul Garg <vakul.garg@nxp.com>

I don't think this is correct.

Here, the stream parser has given us a complete TLS record.

But we haven't decrypted this packet yet.  It sits on the
stream parser's queue to be processed by tls_sw_recvmsg(),
not the saved socket's receive queue.