From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v2 net-next] net: phy: add GBit master / slave error detection Date: Tue, 24 Jul 2018 14:41:28 -0700 (PDT) Message-ID: <20180724.144128.1468434522357807010.davem@davemloft.net> References: <83ad664d-6a0b-9da8-49c0-e464908b441d@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org To: hkallweit1@gmail.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:38788 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727643AbeGXWtz (ORCPT ); Tue, 24 Jul 2018 18:49:55 -0400 In-Reply-To: <83ad664d-6a0b-9da8-49c0-e464908b441d@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Heiner Kallweit Date: Sat, 21 Jul 2018 15:48:47 +0200 > Certain PHY's have issues when operating in GBit slave mode and can > be forced to master mode. Examples are RTL8211C, also the Micrel PHY > driver has a DT setting to force master mode. > If two such chips are link partners the autonegotiation will fail. > Standard defines a self-clearing on read, latched-high bit to > indicate this error. Check this bit to inform the user. > > Signed-off-by: Heiner Kallweit > --- > v2: > - Use different error messages depending on whether local PHY uses > manual master/slave configuration. Applied, thank you.