From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] net: ethernet: fs-enet: Use generic CRC32 implementation Date: Wed, 25 Jul 2018 13:42:11 -0700 (PDT) Message-ID: <20180725.134211.849330522483481967.davem@davemloft.net> References: <20180723162020.6221-1-krzk@kernel.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: pantelis.antoniou@gmail.com, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ebiggers3@gmail.com To: krzk@kernel.org Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:55696 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730305AbeGYVzg (ORCPT ); Wed, 25 Jul 2018 17:55:36 -0400 In-Reply-To: <20180723162020.6221-1-krzk@kernel.org> Sender: netdev-owner@vger.kernel.org List-ID: From: Krzysztof Kozlowski Date: Mon, 23 Jul 2018 18:20:20 +0200 > Use generic kernel CRC32 implementation because it: > 1. Should be faster (uses lookup tables), > 2. Removes duplicated CRC generation code, > 3. Uses well-proven algorithm instead of coding it one more time. > > Suggested-by: Eric Biggers > Signed-off-by: Krzysztof Kozlowski Applied.