From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v3] net: ethernet: freescale: Use generic CRC32 implementation Date: Wed, 25 Jul 2018 13:42:17 -0700 (PDT) Message-ID: <20180725.134217.306393798893792554.davem@davemloft.net> References: <20180723161914.6101-1-krzk@kernel.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: fugang.duan@nxp.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ebiggers3@gmail.com To: krzk@kernel.org Return-path: In-Reply-To: <20180723161914.6101-1-krzk@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Krzysztof Kozlowski Date: Mon, 23 Jul 2018 18:19:14 +0200 > Use generic kernel CRC32 implementation because it: > 1. Should be faster (uses lookup tables), > 2. Removes duplicated CRC generation code, > 3. Uses well-proven algorithm instead of coding it one more time. > > Suggested-by: Eric Biggers > Signed-off-by: Krzysztof Kozlowski Applied.