* [PATCH net-next] lan743x: Make symbol lan743x_pm_ops static
@ 2018-07-25 6:11 Wei Yongjun
2018-07-25 16:42 ` Bryan.Whitehead
2018-07-25 23:38 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2018-07-25 6:11 UTC (permalink / raw)
To: Bryan Whitehead, Microchip Linux Driver Support
Cc: Wei Yongjun, netdev, kernel-janitors
Fixes the following sparse warning:
drivers/net/ethernet/microchip/lan743x_main.c:2944:25: warning:
symbol 'lan743x_pm_ops' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/ethernet/microchip/lan743x_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/ethernet/microchip/lan743x_main.c
index cd41911..bb323f2 100644
--- a/drivers/net/ethernet/microchip/lan743x_main.c
+++ b/drivers/net/ethernet/microchip/lan743x_main.c
@@ -2941,7 +2941,7 @@ static int lan743x_pm_resume(struct device *dev)
return 0;
}
-const struct dev_pm_ops lan743x_pm_ops = {
+static const struct dev_pm_ops lan743x_pm_ops = {
SET_SYSTEM_SLEEP_PM_OPS(lan743x_pm_suspend, lan743x_pm_resume)
};
#endif /*CONFIG_PM */
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH net-next] lan743x: Make symbol lan743x_pm_ops static
2018-07-25 6:11 [PATCH net-next] lan743x: Make symbol lan743x_pm_ops static Wei Yongjun
@ 2018-07-25 16:42 ` Bryan.Whitehead
2018-07-25 23:38 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Bryan.Whitehead @ 2018-07-25 16:42 UTC (permalink / raw)
To: weiyongjun1, UNGLinuxDriver; +Cc: netdev, kernel-janitors
> Subject: [PATCH net-next] lan743x: Make symbol lan743x_pm_ops static
>
> Fixes the following sparse warning:
>
> drivers/net/ethernet/microchip/lan743x_main.c:2944:25: warning:
> symbol 'lan743x_pm_ops' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Bryan Whitehead <Bryan.Whitehead@microchip.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] lan743x: Make symbol lan743x_pm_ops static
2018-07-25 6:11 [PATCH net-next] lan743x: Make symbol lan743x_pm_ops static Wei Yongjun
2018-07-25 16:42 ` Bryan.Whitehead
@ 2018-07-25 23:38 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-07-25 23:38 UTC (permalink / raw)
To: weiyongjun1; +Cc: bryan.whitehead, UNGLinuxDriver, netdev, kernel-janitors
From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Wed, 25 Jul 2018 06:11:16 +0000
> Fixes the following sparse warning:
>
> drivers/net/ethernet/microchip/lan743x_main.c:2944:25: warning:
> symbol 'lan743x_pm_ops' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-26 0:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-25 6:11 [PATCH net-next] lan743x: Make symbol lan743x_pm_ops static Wei Yongjun
2018-07-25 16:42 ` Bryan.Whitehead
2018-07-25 23:38 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).