* [PATCH net] netdevsim: don't leak devlink resources
@ 2018-07-25 22:39 Jakub Kicinski
2018-07-26 5:34 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Kicinski @ 2018-07-25 22:39 UTC (permalink / raw)
To: davem; +Cc: dsahern, oss-drivers, netdev, Jakub Kicinski
Devlink resources registered with devlink_resource_register() have
to be unregistered.
Fixes: 37923ed6b8ce ("netdevsim: Add simple FIB resource controller via devlink")
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Quentin Monnet <quentin.monnet@netronome.com>
---
drivers/net/netdevsim/devlink.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/netdevsim/devlink.c b/drivers/net/netdevsim/devlink.c
index ba663e5af168..5135fc371f01 100644
--- a/drivers/net/netdevsim/devlink.c
+++ b/drivers/net/netdevsim/devlink.c
@@ -207,6 +207,7 @@ void nsim_devlink_teardown(struct netdevsim *ns)
struct net *net = nsim_to_net(ns);
bool *reg_devlink = net_generic(net, nsim_devlink_id);
+ devlink_resources_unregister(ns->devlink, NULL);
devlink_unregister(ns->devlink);
devlink_free(ns->devlink);
ns->devlink = NULL;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net] netdevsim: don't leak devlink resources
2018-07-25 22:39 [PATCH net] netdevsim: don't leak devlink resources Jakub Kicinski
@ 2018-07-26 5:34 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-07-26 5:34 UTC (permalink / raw)
To: jakub.kicinski; +Cc: dsahern, oss-drivers, netdev
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Wed, 25 Jul 2018 15:39:27 -0700
> Devlink resources registered with devlink_resource_register() have
> to be unregistered.
>
> Fixes: 37923ed6b8ce ("netdevsim: Add simple FIB resource controller via devlink")
> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> Reviewed-by: Quentin Monnet <quentin.monnet@netronome.com>
Applied and queued up for -stable.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-26 6:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-25 22:39 [PATCH net] netdevsim: don't leak devlink resources Jakub Kicinski
2018-07-26 5:34 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).