From: Al Viro <viro@ZenIV.linux.org.uk>
To: Vakul Garg <vakul.garg@nxp.com>
Cc: netdev@vger.kernel.org, borisp@mellanox.com,
aviadye@mellanox.com, davejwatson@fb.com, davem@davemloft.net
Subject: Re: [PATCH net-next] net/tls: Do not call msg_data_left() twice
Date: Wed, 25 Jul 2018 02:49:20 +0100 [thread overview]
Message-ID: <20180725014920.GJ30522@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20180724111118.15415-1-vakul.garg@nxp.com>
On Tue, Jul 24, 2018 at 04:41:18PM +0530, Vakul Garg wrote:
> In function tls_sw_sendmsg(), msg_data_left() needs to be called only
> once. The second invocation of msg_data_left() for assigning variable
> try_to_copy can be removed and merged with the first one.
You do realize that msg_data_left(msg) is simply msg->msg_iter.count?
So I'm not at all sure that your change will be an overall win...
next prev parent reply other threads:[~2018-07-25 2:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 11:11 [PATCH net-next] net/tls: Do not call msg_data_left() twice Vakul Garg
2018-07-25 1:49 ` Al Viro [this message]
2018-07-25 1:54 ` Vakul Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180725014920.GJ30522@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=aviadye@mellanox.com \
--cc=borisp@mellanox.com \
--cc=davejwatson@fb.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=vakul.garg@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox