From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH net-next v3 0/5] TC: refactor act_mirred packets re-injection Date: Wed, 25 Jul 2018 14:17:34 +0200 Message-ID: <20180725121734.GE2164@nanopsycho> References: <20180725115345.GC2164@nanopsycho> <168de66002c665d817e7ad5f3137a7db42b0bec9.camel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, Jamal Hadi Salim , Cong Wang , Daniel Borkmann , Marcelo Ricardo Leitner , Eyal Birger , "David S. Miller" To: Paolo Abeni Return-path: Received: from mail-wr1-f49.google.com ([209.85.221.49]:34139 "EHLO mail-wr1-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728901AbeGYNb2 (ORCPT ); Wed, 25 Jul 2018 09:31:28 -0400 Received: by mail-wr1-f49.google.com with SMTP id c13-v6so7219360wrt.1 for ; Wed, 25 Jul 2018 05:20:01 -0700 (PDT) Content-Disposition: inline In-Reply-To: <168de66002c665d817e7ad5f3137a7db42b0bec9.camel@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: Wed, Jul 25, 2018 at 02:07:15PM CEST, pabeni@redhat.com wrote: >Hi, > >On Wed, 2018-07-25 at 13:53 +0200, Jiri Pirko wrote: >> Could you please send the userspace iproute2 patch and list some >> examples of usage along with the next patchset version? > >There are no iproute2 patches, as TC_ACT_REINJECT is not accessible >from user-space: act_mirred will use such value when possible. Okay. > >User-space can have any notion of the above only via the perf tool >and/or performances tests ;) > >An use case is the OVS TC S/W datapath. openvswitch alreday leverage >this when configured with: > >other_config:hw-offload=true >other_config:tc-policy=none > >> Also, I would like you to do selftest script to test this and have it as >> a part of this patchset. > >As said, there is no user-space change. AFAICS the current act_mirred >self tests already cover this. Do you have other things in mind? Sounds allright. Thanks for the explanation! > >Cheers, > >Paolo >