From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH net-next v3 3/5] tc/act: remove unneeded RCU lock in action callback Date: Wed, 25 Jul 2018 14:32:53 +0200 Message-ID: <20180725123253.GG2164@nanopsycho> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, Jamal Hadi Salim , Cong Wang , Daniel Borkmann , Marcelo Ricardo Leitner , Eyal Birger , "David S. Miller" To: Paolo Abeni Return-path: Received: from mail-wm0-f65.google.com ([74.125.82.65]:40055 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728492AbeGYNqu (ORCPT ); Wed, 25 Jul 2018 09:46:50 -0400 Received: by mail-wm0-f65.google.com with SMTP id y9-v6so5040316wma.5 for ; Wed, 25 Jul 2018 05:35:20 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Tue, Jul 24, 2018 at 10:06:41PM CEST, pabeni@redhat.com wrote: >Each lockless action currently does its own RCU locking in ->act(). >This is allows using plain RCU accessor, even if the context >is really RCU BH. > >This change drops the per action RCU lock, replace the accessors >with _bh variant, cleans up a bit the surronding code and documents s/surronding/surrounding/ >the RCU status in the relevant header. >No functional nor performance change is intended. > >The goal of this patch is clarifying that the RCU critical section >used by the tc actions extends up to the classifier's caller. > >v1 -> v2: > - preserve rcu lock in act_bpf: it's needed by eBPF helpers, > as pointed out by Daniel > >Signed-off-by: Paolo Abeni Acked-by: Jiri Pirko