From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH] net: sched: cls_api: fix dead code in switch Date: Wed, 25 Jul 2018 16:31:23 +0200 Message-ID: <20180725143123.GO2164@nanopsycho> References: <20180725140724.GA23053@embeddedor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jiri Pirko , Jamal Hadi Salim , Cong Wang , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: "Gustavo A. R. Silva" Return-path: Content-Disposition: inline In-Reply-To: <20180725140724.GA23053@embeddedor.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Wed, Jul 25, 2018 at 04:07:24PM CEST, gustavo@embeddedor.com wrote: >Code at line 1850 is unreachable. Fix this by removing the break >statement above it, so the code for case RTM_GETCHAIN can be >properly executed. > >Addresses-Coverity-ID: 1472050 ("Structurally dead code") >Fixes: 32a4f5ecd738 ("net: sched: introduce chain object to uapi") >Signed-off-by: Gustavo A. R. Silva Acked-by: Jiri Pirko I'm just writing a selftest to test this path. Thanks.