From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Ricardo Leitner Subject: Re: [PATCH net-next v3 3/5] tc/act: remove unneeded RCU lock in action callback Date: Wed, 25 Jul 2018 15:24:08 -0300 Message-ID: <20180725182406.GD20383@localhost.localdomain> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Paolo Abeni , netdev@vger.kernel.org, Cong Wang , Jiri Pirko , Daniel Borkmann , Eyal Birger , "David S. Miller" To: Jamal Hadi Salim Return-path: Received: from mail-qt0-f180.google.com ([209.85.216.180]:40263 "EHLO mail-qt0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729187AbeGYThD (ORCPT ); Wed, 25 Jul 2018 15:37:03 -0400 Received: by mail-qt0-f180.google.com with SMTP id h4-v6so8603760qtj.7 for ; Wed, 25 Jul 2018 11:24:12 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Wed, Jul 25, 2018 at 07:59:48AM -0400, Jamal Hadi Salim wrote: > On 24/07/18 04:06 PM, Paolo Abeni wrote: > > Each lockless action currently does its own RCU locking in ->act(). > > This is allows using plain RCU accessor, even if the context > > is really RCU BH. > > > > This change drops the per action RCU lock, replace the accessors > > with _bh variant, cleans up a bit the surronding code and documents > > the RCU status in the relevant header. > > No functional nor performance change is intended. > > > > The goal of this patch is clarifying that the RCU critical section > > used by the tc actions extends up to the classifier's caller. > > > > This and 2/5 seems to stand on their own merit. So does 1/5, I think. > > cheers, > jamal