* [PATCH net-next] net: hns: make hns_dsaf_roce_reset non static
@ 2018-07-27 1:53 YueHaibing
2018-07-27 4:19 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2018-07-27 1:53 UTC (permalink / raw)
To: davem, yisen.zhuang, salil.mehta
Cc: linux-kernel, netdev, linyunsheng, matthias.bgg, lipeng321,
YueHaibing
hns_dsaf_roce_reset is exported and used in hns_roce_hw_v1.c
In commit 336a443bd9dd ("net: hns: Make many functions static") I make
it static wrongly.
drivers/infiniband/hw/hns/hns_roce_hw_v1.o: In function `hns_roce_v1_reset':
hns_roce_hw_v1.c:(.text+0x37ac): undefined reference to `hns_dsaf_roce_reset'
hns_roce_hw_v1.c:(.text+0x37cc): undefined reference to `hns_dsaf_roce_reset'
Fixes: 336a443bd9dd ("net: hns: Make many functions static")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c
index 7afc675..619e6ce 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c
@@ -2836,7 +2836,7 @@ module_platform_driver(g_dsaf_driver);
* @enable: false - request reset , true - drop reset
* retuen 0 - success , negative -fail
*/
-static int hns_dsaf_roce_reset(struct fwnode_handle *dsaf_fwnode, bool dereset)
+int hns_dsaf_roce_reset(struct fwnode_handle *dsaf_fwnode, bool dereset)
{
struct dsaf_device *dsaf_dev;
struct platform_device *pdev;
--
2.7.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: hns: make hns_dsaf_roce_reset non static
2018-07-27 1:53 [PATCH net-next] net: hns: make hns_dsaf_roce_reset non static YueHaibing
@ 2018-07-27 4:19 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-07-27 4:19 UTC (permalink / raw)
To: yuehaibing
Cc: yisen.zhuang, salil.mehta, linux-kernel, netdev, linyunsheng,
matthias.bgg, lipeng321
From: YueHaibing <yuehaibing@huawei.com>
Date: Fri, 27 Jul 2018 09:53:12 +0800
> hns_dsaf_roce_reset is exported and used in hns_roce_hw_v1.c
> In commit 336a443bd9dd ("net: hns: Make many functions static") I make
> it static wrongly.
>
> drivers/infiniband/hw/hns/hns_roce_hw_v1.o: In function `hns_roce_v1_reset':
> hns_roce_hw_v1.c:(.text+0x37ac): undefined reference to `hns_dsaf_roce_reset'
> hns_roce_hw_v1.c:(.text+0x37cc): undefined reference to `hns_dsaf_roce_reset'
>
> Fixes: 336a443bd9dd ("net: hns: Make many functions static")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Oops, applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-27 4:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-27 1:53 [PATCH net-next] net: hns: make hns_dsaf_roce_reset non static YueHaibing
2018-07-27 4:19 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).