From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] isdn: hisax: config: Replace GFP_ATOMIC with GFP_KERNEL Date: Thu, 26 Jul 2018 21:25:07 -0700 (PDT) Message-ID: <20180726.212507.209809359488602241.davem@davemloft.net> References: <20180727024828.2107-1-baijiaju1990@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: isdn@linux-pingi.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: baijiaju1990@gmail.com Return-path: In-Reply-To: <20180727024828.2107-1-baijiaju1990@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Jia-Ju Bai Date: Fri, 27 Jul 2018 10:48:28 +0800 > hisax_cs_new() and hisax_cs_setup() are never called in atomic context. > They call kmalloc() and kzalloc() with GFP_ATOMIC, which is not necessary. > GFP_ATOMIC can be replaced with GFP_KERNEL. > > This is found by a static analysis tool named DCNS written by myself. > > Signed-off-by: Jia-Ju Bai Applied.