From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dominique Martinet Subject: Re: [PATCH] 9p: fix NULL pointer dereferences Date: Thu, 26 Jul 2018 10:17:27 +0200 Message-ID: <20180726081727.GA6699@nautica> References: <20180726081049.10527-1-tomasbortoli@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: davem@davemloft.net, v9fs-developer@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller@googlegroups.com To: Tomas Bortoli Return-path: Content-Disposition: inline In-Reply-To: <20180726081049.10527-1-tomasbortoli@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Tomas Bortoli wrote on Thu, Jul 26, 2018: > In p9_fd_create_tcp() and p9_fd_create_unix() it is possible to get > a NULL value in the addr parameter. Return -EINVAL in such cases. Let's refuse that at much higher level, like v9fs_mount() in fs/9p/vfs_super.c I can't think of any valid reason for dev_name to be NULL, it's the target IP or virtio handle. -- Dominique