From: Dominique Martinet <asmadeus@codewreck.org>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: Tomas Bortoli <tomasbortoli@gmail.com>,
David Miller <davem@davemloft.net>,
v9fs-developer@lists.sourceforge.net,
netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
syzkaller <syzkaller@googlegroups.com>
Subject: Re: [PATCH] 9p: fix NULL pointer dereferences
Date: Thu, 26 Jul 2018 11:48:49 +0200 [thread overview]
Message-ID: <20180726094849.GA18334@nautica> (raw)
In-Reply-To: <CACT4Y+ark+0EYSZaOX-qDKpOkyfLgSO9CkidZzx=xkUuhpr65A@mail.gmail.com>
Dmitry Vyukov wrote on Thu, Jul 26, 2018:
> > Let's refuse that at much higher level, like v9fs_mount() in
> > fs/9p/vfs_super.c
> >
> > I can't think of any valid reason for dev_name to be NULL, it's the
> > target IP or virtio handle.
>
> But I think trans=fd allows NULL addr today, no?
Ah, right, I read the patch too fast and read unix_create as fd_create,
I never realized there was a unix_create variant...
fd legitimately doesn't need a name, you are correct.
I'm really curious if anyone ever uses the unix/fd variants for "real"
stuff though! (not meaning syzbot isn't real, but I have yet to see
anything take advantage of this, even if I could imagine some fun
applications by piping the wmii libixp server socket.. and just crashed
my laptop trying because of the (fixed) trans put bug.. I have yet to
see anyone actually doing this)
On the other hand, virtio, rdma and xen all have the same problem, so
Thomas, please fix them instead :)
--
Dominique Martinet
next prev parent reply other threads:[~2018-07-26 9:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-26 8:10 [PATCH] 9p: fix NULL pointer dereferences Tomas Bortoli
2018-07-26 8:17 ` Dominique Martinet
2018-07-26 9:27 ` Dmitry Vyukov
2018-07-26 9:48 ` Dominique Martinet [this message]
2018-07-26 9:54 ` Dmitry Vyukov
2018-07-26 10:25 ` Dominique Martinet
2018-07-26 14:13 ` Tomas Bortoli
2018-07-26 14:21 ` Dominique Martinet
2018-07-26 14:32 ` Tomas Bortoli
2018-07-26 22:15 ` Dominique Martinet
2018-08-08 15:51 ` Dmitry Vyukov
2018-08-08 22:41 ` Dominique Martinet
2018-07-26 14:48 ` [V9fs-developer] " sqweek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180726094849.GA18334@nautica \
--to=asmadeus@codewreck.org \
--cc=davem@davemloft.net \
--cc=dvyukov@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzkaller@googlegroups.com \
--cc=tomasbortoli@gmail.com \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).