netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch net-next] net: sched: unmark chain as explicitly created on delete
@ 2018-07-26 16:27 Jiri Pirko
  2018-07-26 21:13 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Jiri Pirko @ 2018-07-26 16:27 UTC (permalink / raw)
  To: netdev; +Cc: davem, jhs, xiyou.wangcong, mlxsw

From: Jiri Pirko <jiri@mellanox.com>

Once user manually deletes the chain using "chain del", the chain cannot
be marked as explicitly created anymore.

Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Fixes: 32a4f5ecd738 ("net: sched: introduce chain object to uapi")
---
 net/sched/cls_api.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
index f3d78c23338e..75cce2819de9 100644
--- a/net/sched/cls_api.c
+++ b/net/sched/cls_api.c
@@ -1844,6 +1844,7 @@ static int tc_ctl_chain(struct sk_buff *skb, struct nlmsghdr *n,
 		 * to the chain previously taken during addition.
 		 */
 		tcf_chain_put_explicitly_created(chain);
+		chain->explicitly_created = false;
 		break;
 	case RTM_GETCHAIN:
 		err = tc_chain_notify(chain, skb, n->nlmsg_seq,
-- 
2.14.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [patch net-next] net: sched: unmark chain as explicitly created on delete
  2018-07-26 16:27 [patch net-next] net: sched: unmark chain as explicitly created on delete Jiri Pirko
@ 2018-07-26 21:13 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-07-26 21:13 UTC (permalink / raw)
  To: jiri; +Cc: netdev, jhs, xiyou.wangcong, mlxsw

From: Jiri Pirko <jiri@resnulli.us>
Date: Thu, 26 Jul 2018 18:27:58 +0200

> From: Jiri Pirko <jiri@mellanox.com>
> 
> Once user manually deletes the chain using "chain del", the chain cannot
> be marked as explicitly created anymore.
> 
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
> Fixes: 32a4f5ecd738 ("net: sched: introduce chain object to uapi")

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-07-26 22:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-26 16:27 [patch net-next] net: sched: unmark chain as explicitly created on delete Jiri Pirko
2018-07-26 21:13 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).